Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable offloading of literals by default #6246

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Disable offloading of literals by default #6246

merged 1 commit into from
Feb 14, 2025

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Feb 14, 2025 •
edited by flyte-bot
Loading

Tracking issue

NA

Why are the changes needed?

We shipped offloading of literals by default in Flyte 1.14, but unfortunately given the limitations that feature currently exposes we feel that having that enabled by default is too disruptive, so instead, we're taking a more measured approach and once we feel the feature is ready for production we'll ship it by default.

A list of the limitations:

  • lack of support for @dynamic
  • UI doesn't show inputs/outputs
  • lack of support for offloaded literals in FlyteRemote
  • lack of support for Jupyter Notebook

What changes were proposed in this pull request?

Set the flag to false in both single binary and flyte-core helm charts.

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This PR implements a significant change by disabling the literal offloading feature by default across all Flyte deployment configurations (AWS EKS, GCP, and sandbox). The change involves setting 'literalOffloadingConfigEnabled' to false in helm charts and removing related configurations from deployment manifests to address production environment limitations.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 3

@flyte-bot
Copy link
Collaborator

flyte-bot commented Feb 14, 2025 •
edited
Loading

Code Review Agent Run #574bbe

Actionable Suggestions - 1
  • charts/flyte-core/values.yaml - 1
    • Consider impact of disabling literal offloading · Line 867-867
Review Details
  • Files reviewed - 12 · Commit Range: 7aac79c..7aac79c
    • charts/flyte-binary/values.yaml
    • charts/flyte-core/values.yaml
    • deployment/eks/flyte_aws_scheduler_helm_generated.yaml
    • deployment/eks/flyte_helm_dataplane_generated.yaml
    • deployment/eks/flyte_helm_generated.yaml
    • deployment/gcp/flyte_helm_dataplane_generated.yaml
    • deployment/gcp/flyte_helm_generated.yaml
    • deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
    • deployment/sandbox/flyte_helm_generated.yaml
    • docker/sandbox-bundled/manifests/complete-agent.yaml
    • docker/sandbox-bundled/manifests/complete.yaml
    • docker/sandbox-bundled/manifests/dev.yaml
  • Files skipped - 2
    • charts/flyte-binary/README.md - Reason: Filter setting
    • charts/flyte-core/README.md - Reason: Filter setting
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.86%. Comparing base (b04df59) to head (7aac79c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6246       +/-   ##
===========================================
- Coverage   50.51%   36.86%   -13.65%     
===========================================
  Files        1162     1318      +156     
  Lines       91811   134703    +42892     
===========================================
+ Hits        46375    49662     +3287     
- Misses      41340    80714    +39374     
- Partials     4096     4327      +231
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 51.91% <ø> (-0.03%) ⬇️
unittests-flytecopilot 30.99% <ø> (?)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.22% <ø> (?)
unittests-flyteplugins 54.03% <ø> (ø)
unittests-flytepropeller 42.78% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) February 14, 2025 20:23
@flyte-bot
Copy link
Collaborator

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Disable Literal Offloading Configuration

- values.yaml - Disabled literal offloading configuration

- values.yaml - Disabled literal offloading feature

- flyte_aws_scheduler_helm_generated.yaml - Updated configuration and disabled literal offloading

- flyte_helm_dataplane_generated.yaml - Updated configuration checksums and disabled literal offloading

- flyte_helm_generated.yaml - Disabled literal offloading and updated configuration checksums

- flyte_sandbox_binary_helm_generated.yaml - Removed literal offloading configuration

- complete-agent.yaml - Updated configuration checksums and removed literal offloading

- complete.yaml - Removed literal offloading configuration and updated checksums

- dev.yaml - Updated shared secrets and configuration checksums

flyte-bot
flyte-bot reviewed Feb 14, 2025
View reviewed changes
charts/flyte-core/values.yaml
@@ -864,7 +864,7 @@ configmap:
rate: 10
capacity: 100
literal-offloading-config:
enabled: true
enabled: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider impact of disabling literal offloading

Consider keeping literal-offloading-config.enabled as true since disabling it may impact large workflow execution performance. If this change is intentional, please provide context on why literal offloading is being disabled.

Code suggestion
Check the AI-generated fix before applying
Suggested change
enabled: false
enabled: true

Code Review Run #574bbe

Is this a valid issue, or was it incorrectly flagged by the Agent?

  • it was incorrectly flagged

@eapolinario eapolinario merged commit 503db30 into master Feb 14, 2025
57 of 58 checks passed
@eapolinario eapolinario deleted the disable-offloading-of-literals-by-default branch February 14, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyte-bot flyte-bot flyte-bot left review comments

@pmahindrakar-oss pmahindrakar-oss pmahindrakar-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eapolinario @flyte-bot @pmahindrakar-oss